fix(ui): keep Space for playback after mouse clicks #5

Merged
tri merged 1 commits from fix/menu-space-key-trap into main 2026-11-11 20:16:12 +07:00
Owner

Header, footer, seek bar, volume slider and playlist controls used Qt.StrongFocus, so a mouse click kept focus on them. After closing the Subtitles/Audio menu, Space reopened it, and after clicking the seek bar Space did nothing.

They now use Qt.TabFocus: clicks leave focus on the video so Space toggles playback, while Tab still reaches every control (KDE HIG).

Tested in the real app under org.kde.union: Space toggles playback after closing the Subtitles menu, clicking the seek bar, the footer play button and the menu bar; Tab still focuses the header buttons and Space activates them.

Header, footer, seek bar, volume slider and playlist controls used Qt.StrongFocus, so a mouse click kept focus on them. After closing the Subtitles/Audio menu, Space reopened it, and after clicking the seek bar Space did nothing. They now use Qt.TabFocus: clicks leave focus on the video so Space toggles playback, while Tab still reaches every control (KDE HIG). Tested in the real app under org.kde.union: Space toggles playback after closing the Subtitles menu, clicking the seek bar, the footer play button and the menu bar; Tab still focuses the header buttons and Space activates them.
tri added 1 commit 2026-11-11 20:15:01 +07:00
Controls take focus only via Tab, so a click leaves Space for playback.
tri merged commit 41188fc665 into main 2026-11-11 20:16:12 +07:00
tri deleted branch fix/menu-space-key-trap 2026-11-11 20:16:12 +07:00
Sign in to join this conversation.